@DM_Ronin If Codeberg (in fact, Gitea) was as accessible for screen reader users as Github is, then that would be a great move.
@menelion I am starting work on improving the accessibility of @forgejo (and thus @Codeberg) over the coming months. I know there is a lot to be done. But if you have any suggestions of things that are _especially_ bad that make Forgejo hard or impossible to use, please let me know. It might be hard to file issues if Codeberg isn't accessible to you, so feel free to message me directly here or on Matrix. Cheers!
@menelion Thanks for the useful feedback. I can see that PR reviews in particular could be a challenging area to solve – if GitHub is better in this regard it will be instructive to look at how they solved that. I'll be making some architectural changes to the front-end code first, but later I might contact you for feedback on changes I make if that's ok with you.
(I do also realise you have sent some feedback before to other team members; thank you for that.)
@forgejo @Codeberg @DM_Ronin
@caesar @forgejo @Codeberg @DM_Ronin It's totally OK, but please use Mastodon, email, Telegram, but not Matrix as at least for me it's also super painful accessibility-wise. I did one small improvement in Gitea regarding headings navigation for comments in issues. As for Github, they also implemented it on my request. They have a plus button next to each line, which is not a button really. So they added a corresponding ARIA role and provided it with text "Add line comment". They however didn't add accessibility for multi-line commenting which I've been asking for like one and a half years.
@caesar Usually we use virtual cursor or its equivalent on Github when reviewing pull requests, so it's really not intuitive. Otherwise, how to read diffs? I'd prefer something like that: line numbers themselves are clickable and have semantic role of toggle buttons. So basically, I'd click number 5, then click number 10, so a field opens wheree I could comment on lines 5 through 10. Your Gmail example probably would be OK, but again, how do we navigate then?
@menelion that makes perfect sense. If you don't mind, I'll paste some of this feedback into a Codeberg issue later to keep track of it when I get round to implementing this.
@caesar Feel free. Of course you can mention me also. https://codeberg.org/Menelion
@menelion For reference: https://codeberg.org/forgejo/forgejo/issues/998
@caesar Subscribed to notifications.
@menelion a contributor [sent a PR upstream to Gitea](https://github.com/go-gitea/gitea/pull/25894) to change the links to buttons. It's now live in Forgejo v1.20. Would you be able to try it out on https://code.forgejo.org and let me know if it is better or if any more changes are needed to solve that particular issue? Thanks!
@caesar Would you please give me a PR to see the change?
@menelion Sure, what about this one? https://code.forgejo.org/forgejo/runner/pulls/43/files
@caesar Nice, it's a huge step forward! Could you please delete the comment though? I have no permissions or it's not accessible at all, thank you.
@caesar Also, it would be nice to have the comment header ("Menelion commented...") as a real heading for better navigation as it's done on Github.
@menelion I opened an issue to use semantic markup for the comments too: https://codeberg.org/forgejo/forgejo/issues/1121
@caesar Also, now Forgejo has a benefit over Github: on Github you theoretically can comment old lines also. Well, I don't know whether it's a bug or a feature actually. I mean, if there are two lines being compared, both number 3, on Github you can comment both, it seems, however at Forgejo you can comment only the new one.
@menelion I'm a little confused about what you're saying here. I just tried on code.foregjo.org and I was able to comment both an old and a new line with the same line number. Maybe you meant that on Github you can't do that?
@caesar I mean that on Forgejo I see only one Add Comment Line button, could you re-check please? I guess, for the old line it's not really accessible, or I missed something.
@menelion that's strange. Here for example (https://code.forgejo.org/forgejo/runner/pulls/43/files#diff-2d366d68cfab7780b7c13d572a69413998063561) at line 15 which was changed, I'm seeing comment buttons on both the old and the new lines. Looking at the code they both seem to be identical `button` elements with `aria-label="Add line comment"`. Do you only see one button there?
@caesar Aha, sorry. I don't see the buttons when the lines are just the same, is it OK?
@menelion thanks for the feedback! Interesting that the comment actions menu is also inaccessible, looking at it I can see why. It's a link, the only content of which is an SVG icon with no alt text and with `aria-hidden`. I'll open an issue for that too. I'm guessing a `button` would be better than a link for accessibility?
@caesar If it's a dropdown menu, than yes, a `<button>` definitely, plus you'd need to add some ARIA roles to handle this correctly, I guess.
@menelion I've opened an issue for this: https://codeberg.org/forgejo/forgejo/issues/1120
@menelion By the way there were a number of other accessibility improvements in the latest release, including (finally!) a more accessible comment editor. Hopefully that should make opening and responding to issue easier, once v1.20 makes it to Codeberg.