dragonscave.space is one of the many independent Mastodon servers you can use to participate in the fediverse.
A fun, happy little Mastodon/Glitch instance.

Server stats:

239
active users

Public

@DM_Ronin If Codeberg (in fact, Gitea) was as accessible for screen reader users as Github is, then that would be a great move.

Public

@menelion I am starting work on improving the accessibility of @forgejo (and thus @Codeberg) over the coming months. I know there is a lot to be done. But if you have any suggestions of things that are _especially_ bad that make Forgejo hard or impossible to use, please let me know. It might be hard to file issues if Codeberg isn't accessible to you, so feel free to message me directly here or on Matrix. Cheers!

@DM_Ronin

Public

@caesar @forgejo @Codeberg @DM_Ronin Especially hard is to review pull requests. You cannot comment lines of code, this process is totally inaccessible and I even don't know how to tackle it best, frontend is very… specific, so to say, or it's because I'm a backender.

Public

@menelion Thanks for the useful feedback. I can see that PR reviews in particular could be a challenging area to solve – if GitHub is better in this regard it will be instructive to look at how they solved that. I'll be making some architectural changes to the front-end code first, but later I might contact you for feedback on changes I make if that's ok with you.
(I do also realise you have sent some feedback before to other team members; thank you for that.)
@forgejo @Codeberg @DM_Ronin

Public

@caesar @forgejo @Codeberg @DM_Ronin It's totally OK, but please use Mastodon, email, Telegram, but not Matrix as at least for me it's also super painful accessibility-wise. I did one small improvement in Gitea regarding headings navigation for comments in issues. As for Github, they also implemented it on my request. They have a plus button next to each line, which is not a button really. So they added a corresponding ARIA role and provided it with text "Add line comment". They however didn't add accessibility for multi-line commenting which I've been asking for like one and a half years.

Public

@menelion Thanks, that's useful to know. I wonder if for multi-line commenting keyboard navigation like in Gmail would be useful? So you could use up/down keys to highlight lines and X or space to select? @forgejo @Codeberg @DM_Ronin

Public

@caesar Usually we use virtual cursor or its equivalent on Github when reviewing pull requests, so it's really not intuitive. Otherwise, how to read diffs? I'd prefer something like that: line numbers themselves are clickable and have semantic role of toggle buttons. So basically, I'd click number 5, then click number 10, so a field opens wheree I could comment on lines 5 through 10. Your Gmail example probably would be OK, but again, how do we navigate then?

Public

@menelion that makes perfect sense. If you don't mind, I'll paste some of this feedback into a Codeberg issue later to keep track of it when I get round to implementing this.

Public
Codeberg.org[ACCESSIBILITY] PR review is not accessible to screen reader users[Reported on Fediverse](https://dragonscave.space/@menelion/110679713699812355) by @Menelion. Copying here for future reference. - Forgejo version (or commit ref): v1.19 ## Description @Menelion: > Especially hard is to review pull requests. You cannot comment lines of code, this process is totally inaccessible and I even don't know how to tackle it best, frontend is very… specific, so to say, or it's because I'm a backender. @Menelion: > [...] As for Github, they also implemented it on my request. They have a plus button next to each line, which is not a button really. So they added a corresponding ARIA role and provided it with text "Add line comment". They however didn't add accessibility for multi-line commenting which I've been asking for like one and a half years. @caesar: > I wonder if for multi-line commenting keyboard navigation like in Gmail would be useful? So you could use up/down keys to highlight lines and X or space to select? @Menelion: > Usually we use virtual cursor or its equivalent on Github when reviewing pull requests, so it's really not intuitive. Otherwise, how to read diffs? I'd prefer something like that: line numbers themselves are clickable and have semantic role of toggle buttons. So basically, I'd click number 5, then click number 10, so a field opens wheree I could comment on lines 5 through 10. Your Gmail example probably would be OK, but again, how do we navigate then?
Public

@caesar Subscribed to notifications.

Public

@menelion a contributor [sent a PR upstream to Gitea](github.com/go-gitea/gitea/pull) to change the links to buttons. It's now live in Forgejo v1.20. Would you be able to try it out on code.forgejo.org and let me know if it is better or if any more changes are needed to solve that particular issue? Thanks!

GitHubMake `add line comment` buttons focusable by sebastian-sauer · Pull Request #25894 · go-gitea/giteaBy sebastian-sauer
Public

@caesar Would you please give me a PR to see the change?

Public

@menelion thanks for the feedback! Interesting that the comment actions menu is also inaccessible, looking at it I can see why. It's a link, the only content of which is an SVG icon with no alt text and with `aria-hidden`. I'll open an issue for that too. I'm guessing a `button` would be better than a link for accessibility?

@caesar If it's a dropdown menu, than yes, a `<button>` definitely, plus you'd need to add some ARIA roles to handle this correctly, I guess.